[Continuing #5094] Set language info for dash audio streams and sort#5149
Merged
syeopite merged 2 commits intoiv-org:masterfrom Jan 22, 2025
Merged
Conversation
Contributor
|
Please remove the non-standard bitrate property, the standard bandwidth property is already correctly set on Representations. |
giuliano-macedo
force-pushed
the
add_audio_info_sort_for_default
branch
from
84257df to
5ccec13
Compare
Contributor
Author
|
@absidue Done, thanks! |
syeopite
approved these changes
Jan 21, 2025
- language id - language display name - main/default track Sort audio formats so that main/default is first (for clients not using dash) * Note: this should be a non-breaking change; if audio track info is not availablle, the behavior does not change from current
syeopite
force-pushed
the
add_audio_info_sort_for_default
branch
from
5ccec13 to
6e3ec10
Compare
unixfox
approved these changes
Jan 22, 2025
Member
|
Thanks for the contribution @GTechAlpha and @giuliano-macedo 😄. Great work on this 🎉 |
|
Hi @giuliano-macedo thanks for your work! Now I can select the audio track on videos, however it still defaults to the AI translated instead of original language. Is there any way to change that or did I misunderstand this PR? 
EDIT: Looks like it's being tracked at #5157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing #5094 made by GTechAlpha with its original commit since it hasn't had new changes for more than a month. I'm doing this by changing how the AdaptionSet label is set when there is multilang audio available but displays the birate so that it avoids #3074.
Screenshots:
Original PR description
Set audio track info, if present, in dash manifest
Sort audio formats so that main/default is first (for clients not using dash)
This resolves issue of incorrect/undesired audio when automatic translation is enabled by content creator (currently relatively rare, but likely to increase), and allows dash clients to correctly select default language and optionally offer multiple language streams.
closes #2007
Note: this should be a non-breaking change; if audio track info is not available, the behavior does not change from current